Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical hits on skill use are not reported in notifications #8128

Open
SabreCat opened this issue Oct 12, 2016 · 8 comments · May be fixed by #14696
Open

Critical hits on skill use are not reported in notifications #8128

SabreCat opened this issue Oct 12, 2016 · 8 comments · May be fixed by #14696
Assignees
@lstanford53
Labels
priority: minor section: Achievements/Popups/Notifications section: Task Page

Comments

@SabreCat
Copy link
Member

SabreCat commented Oct 12, 2016 •
edited
Loading

General Info

  • UUID: haha
  • Browser: Chrome
  • OS: Windows 10

Description

It is possible to score a critical hit with actions like Brutal Smash, lending a modest boost to the damage done to a boss. However, unlike critical hits when scoring tasks, there is no feedback in notifications that this has occurred. In the past, this was difficult to notice, but now that we have immediate output of boss damage, it's clear that sometimes you randomly get more progress without any indication as to why. We should fire the critical hit starburst including the relevant bonus amount when landing skill crits.

Console Errors

None
@librarianmage
Copy link
Contributor

Is this still an issue?

@HabitRPG HabitRPG deleted a comment from sjyn Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from SabreCat Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from 32gits Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from 32gits Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from sjyn Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from librarianmage Feb 5, 2020
@HabitRPG HabitRPG deleted a comment from SabreCat Feb 5, 2020
@Alys
Copy link
Contributor

Alys commented Feb 5, 2020

Yes, this is still an issue.

Note to anyone working on this, currently you can't see how much boss damage you do from notifications due to #11828 but you can watch how your test account's party.quest.progress.up changes in your local database.

I've removed some old comments from this issue (just requests to work on this and confirmations/questions related to them).

@HerrMoriden
Copy link

is this still an issue ? would like to work on this

@Alys
Copy link
Contributor

Alys commented Nov 16, 2020

@HerrMoriden You have a couple of other issues assigned to you so we'll keep this one open for someone else to work on. When you've finished the other issues, post again here if you'd like to claim this one. Please see this comment from Matteo about claiming just one issue at a time.

@lstanford53
Copy link

Hi, does this still need to be implemented? I looked into the code and I think I'd be able to implement this. Let me know if I can help.

@CuriousMagpie
Copy link
Member

@lstanford53 Feel free to take this on! Thanks!

@lstanford53
Copy link

Sure, I'll start on it now.

@lstanford53
Copy link

@CuriousMagpie Hello, I have opened a PR that fixes this issue. Here's the link: #14696

@CuriousMagpie CuriousMagpie linked a pull request Jun 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstanford53 lstanford53

Labels
priority: minor section: Achievements/Popups/Notifications section: Task Page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show a notification when a critical hit occurs while using a spell. lstanford53/habitica
9 participants
@Alys @lemoness @SabreCat @beffymaroo @librarianmage @saraolson @lstanford53 @HerrMoriden @CuriousMagpie