Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report explorer error when looking at a report definition: undefined method `=~' for an instance of Integer [report/tree_select] #9357

Open
jrafanie opened this issue Feb 20, 2025 · 1 comment · May be fixed by ManageIQ/manageiq#23349
Open

Report explorer error when looking at a report definition: undefined method `=~' for an instance of Integer [report/tree_select] #9357

jrafanie opened this issue Feb 20, 2025 · 1 comment · May be fixed by ManageIQ/manageiq#23349
Assignees
@jrafanie
Labels
bug

Comments

@jrafanie
Copy link
Member

Image

Happens in both rails 7.0 and 7.1:

7.0 output: 
[----] I, [2025-02-20T13:31:17.372822#93840:f3f20]  INFO -- : Started POST "/report/tree_select?id=xx-0_xx-0-0_rep-2&text=VMs%2520w%252FFree%2520Space%2520%2526gt%253B%252075%2525%2520by%2520Function" for ::1 at 2025-02-20 13:31:17 -0500
[----] I, [2025-02-20T13:31:17.440025#93840:f3f20]  INFO -- : Processing by ReportController#tree_select as JS
[----] I, [2025-02-20T13:31:17.440072#93840:f3f20]  INFO -- :   Parameters: {"id"=>"xx-0_xx-0-0_rep-2", "text"=>"VMs%20w%2FFree%20Space%20%26gt%3B%2075%25%20by%20Function"}
[----] D, [2025-02-20T13:31:17.441640#93840:f3f20] DEBUG -- : PostgreSQLAdapter#log_after_checkout, connection_pool: size: 15, connections: 4, in use: 1, waiting_in_queue: 0
[----] D, [2025-02-20T13:31:17.442318#93840:f3f20] DEBUG -- :   User Load (0.4ms)  SELECT "users".* FROM "users" WHERE "users"."id" BETWEEN $1 AND $2 AND "users"."userid" = $3 LIMIT $4  [["id", 0], ["id", 999999999999], ["userid", "admin"], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.442480#93840:f3f20] DEBUG -- :   User Inst Including Associations (0.1ms - 1rows)
[----] D, [2025-02-20T13:31:17.442972#93840:f3f20] DEBUG -- :   MiqGroup Load (0.2ms)  SELECT "miq_groups".* FROM "miq_groups" WHERE "miq_groups"."id" = $1 LIMIT $2  [["id", 2], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.443062#93840:f3f20] DEBUG -- :   MiqGroup Inst Including Associations (0.0ms - 1rows)
[----] D, [2025-02-20T13:31:17.443438#93840:f3f20] DEBUG -- :   Tenant Load (0.2ms)  SELECT "tenants".* FROM "tenants" WHERE "tenants"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.443529#93840:f3f20] DEBUG -- :   Tenant Inst Including Associations (0.0ms - 1rows)
[----] D, [2025-02-20T13:31:17.445039#93840:f3f20] DEBUG -- :   MiqUserRole Load (0.4ms)  SELECT "miq_user_roles".* FROM "miq_user_roles" INNER JOIN "entitlements" ON "miq_user_roles"."id" = "entitlements"."miq_user_role_id" WHERE "entitlements"."miq_group_id" = $1 LIMIT $2  [["miq_group_id", 2], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.445162#93840:f3f20] DEBUG -- :   MiqUserRole Inst Including Associations (0.0ms - 1rows)
[----] D, [2025-02-20T13:31:17.446027#93840:f3f20] DEBUG -- :   MiqProductFeature Pluck (0.5ms)  SELECT "miq_product_features"."identifier" FROM "miq_product_features" INNER JOIN "miq_roles_features" ON "miq_product_features"."id" = "miq_roles_features"."miq_product_feature_id" WHERE "miq_roles_features"."miq_user_role_id" = $1  [["miq_user_role_id", 1]]
[----] D, [2025-02-20T13:31:17.446875#93840:f3f20] DEBUG -- :   MiqReport Exists? (0.3ms)  SELECT 1 AS one FROM "miq_reports" WHERE "miq_reports"."id" = $1 LIMIT $2  [["id", 2], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.447461#93840:f3f20] DEBUG -- :   MiqReport Load (0.3ms)  SELECT "miq_reports".* FROM "miq_reports" WHERE "miq_reports"."id" = $1 LIMIT $2  [["id", 2], ["LIMIT", 1]]
[----] D, [2025-02-20T13:31:17.447606#93840:f3f20] DEBUG -- :   MiqReport Inst Including Associations (0.0ms - 1rows)
[----] D, [2025-02-20T13:31:17.448066#93840:f3f20] DEBUG -- :   MiqSchedule Load (0.3ms)  SELECT "miq_schedules".* FROM "miq_schedules" WHERE "miq_schedules"."resource_type" = $1  [["resource_type", "MiqReport"]]
[----] D, [2025-02-20T13:31:17.448819#93840:f3f20] DEBUG -- :   MiqWidget Load (0.2ms)  SELECT "miq_widgets".* FROM "miq_widgets" WHERE "miq_widgets"."resource_id" = $1 AND "miq_widgets"."resource_type" = $2  [["resource_id", 2], ["resource_type", "MiqReport"]]
[----] D, [2025-02-20T13:31:17.448907#93840:f3f20] DEBUG -- :   MiqWidget Inst Including Associations (0.0ms - 0rows)
[----] D, [2025-02-20T13:31:17.449643#93840:f3f20] DEBUG -- :   MiqReportResult Maximum (0.4ms)  SELECT MAX("miq_report_results"."created_on") FROM "miq_report_results" WHERE "miq_report_results"."miq_report_id" IS NOT NULL AND "miq_report_results"."miq_group_id" IS NOT NULL
[----] D, [2025-02-20T13:31:17.450677#93840:f3f20] DEBUG -- :   Rendered /Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/layouts/_flash_msg.html.haml (Duration: 0.0ms | Allocations: 12)
[----] D, [2025-02-20T13:31:17.458551#93840:f3f20] DEBUG -- :   Rendered /Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/report/_report_info.html.erb (Duration: 7.7ms | Allocations: 2767)
[----] D, [2025-02-20T13:31:17.458635#93840:f3f20] DEBUG -- :   Rendered /Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/report/_report_list.html.haml (Duration: 8.1ms | Allocations: 3101)
[----] F, [2025-02-20T13:31:17.458710#93840:f3f20] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `=~' for an instance of Integer
/Users/joerafaniello/Code/manageiq-testing/lib/miq_expression.rb:809:in `quote_human'
/Users/joerafaniello/Code/manageiq-testing/lib/miq_expression.rb:633:in `operands2humanvalue'
/Users/joerafaniello/Code/manageiq-testing/lib/miq_expression.rb:119:in `_to_human'
/Users/joerafaniello/Code/manageiq-testing/lib/miq_expression.rb:140:in `_to_human'
/Users/joerafaniello/Code/manageiq-testing/lib/miq_expression.rb:108:in `to_human'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/helpers/report_helper/report_information_helper.rb:20:in `report_information'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/helpers/report_helper/report_information_helper.rb:5:in `report_info_summary'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/report/_report_info.html.erb:2:in `___sers_joerafaniello__gem_ruby_______bundler_gems_manageiq_ui_classic___d____b_____app_views_report__report_info_html_erb__1832693035000393505_1003780'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:244:in `public_send'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:244:in `_run'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:157:in `block in render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:208:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:361:in `instrument_render_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:155:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:251:in `block in render_partial_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:206:in `block in instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:206:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:246:in `render_partial_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:237:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/renderer.rb:81:in `render_partial_to_object'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/renderer.rb:27:in `render_to_object'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/renderer.rb:22:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/rendering_helper.rb:37:in `block in render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:270:in `in_rendering_context'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/rendering_helper.rb:33:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/jquery-rjs-0.1.1.3/lib/jquery-rjs/rendering.rb:9:in `block in <module:RenderingHelper>'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/report/_report_list.html.haml:35:in `block in ___sers_joerafaniello__gem_ruby_______bundler_gems_manageiq_ui_classic___d____b_____app_views_report__report_list_html_haml___4550957002005924932_1003700'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/helpers/application_helper.rb:1164:in `block in miq_tab_content'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/capture_helper.rb:45:in `block in capture'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/capture_helper.rb:209:in `with_output_buffer'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/capture_helper.rb:45:in `capture'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/helpers/tag_helper.rb:371:in `content_tag'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/helpers/application_helper.rb:1163:in `miq_tab_content'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/views/report/_report_list.html.haml:34:in `___sers_joerafaniello__gem_ruby_______bundler_gems_manageiq_ui_classic___d____b_____app_views_report__report_list_html_haml___4550957002005924932_1003700'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:244:in `public_send'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:244:in `_run'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:157:in `block in render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:208:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:361:in `instrument_render_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/template.rb:155:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:251:in `block in render_partial_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:206:in `block in instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.7/lib/active_support/notifications.rb:206:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:246:in `render_partial_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/partial_renderer.rb:237:in `render'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/renderer.rb:81:in `render_partial_to_object'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/renderer/renderer.rb:27:in `render_to_object'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/rendering.rb:117:in `block in _render_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/base.rb:270:in `in_rendering_context'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/rendering.rb:116:in `_render_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/action_controller/metal/streaming.rb:216:in `_render_template'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.0.8.7/lib/action_view/rendering.rb:103:in `render_to_body'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/action_controller/metal/rendering.rb:158:in `render_to_body'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/action_controller/metal/renderers.rb:141:in `render_to_body'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/abstract_controller/rendering.rb:45:in `render_to_string'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/action_controller/metal/rendering.rb:147:in `render_to_string'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/helpers/application_helper.rb:1288:in `block in r'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/report_controller.rb:689:in `replace_right_cell'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/report_controller.rb:209:in `tree_select'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.0.8.7/lib/action_controller/metal/basic_implicit_render.rb:6:in `s...
@jrafanie jrafanie added the bug label Feb 20, 2025
@jrafanie
Copy link
Member Author

jrafanie commented Feb 20, 2025 •
edited
Loading

Looks like a bug in quote_human... I assume at some point, some numeric values were strings but are now sometimes/always actual integers.

@jrafanie jrafanie self-assigned this Feb 20, 2025
jrafanie added a commit to jrafanie/manageiq that referenced this issue Feb 20, 2025
@jrafanie
Numerics shouldn't be tested for ".bytes" like suffix
07ca05e 
Symbols or other non-strings should be converted to strings before testing the regex.

Fixes ManageIQ/manageiq-ui-classic#9357
@jrafanie jrafanie linked a pull request Feb 20, 2025 that will close this issue
Open
jrafanie added a commit to jrafanie/manageiq that referenced this issue Feb 20, 2025
@jrafanie
Numerics shouldn't be tested for ".bytes" like suffix
1e25ed3 
Symbols or other non-strings should be converted to strings before testing the regex.

Fixes ManageIQ/manageiq-ui-classic#9357
jrafanie added a commit to jrafanie/manageiq that referenced this issue Feb 20, 2025
@jrafanie
Numerics shouldn't be tested for ".bytes" like suffix
5fe17ef 
Symbols or other non-strings should be converted to strings before testing the regex.

Fixes ManageIQ/manageiq-ui-classic#9357
jrafanie added a commit to jrafanie/manageiq that referenced this issue Feb 20, 2025
@jrafanie
Numerics shouldn't be tested for ".bytes" like suffix
11a32fb 
Symbols or other non-strings should be converted to strings before testing the regex.

Fixes ManageIQ/manageiq-ui-classic#9357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrafanie jrafanie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Numerics shouldn't be tested for ".bytes" like suffix jrafanie/manageiq
1 participant
@jrafanie