Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log service support #11

Closed
subfuzion opened this issue Aug 9, 2016 · 2 comments
Closed

Add log service support #11

subfuzion opened this issue Aug 9, 2016 · 2 comments

Comments

@subfuzion
Copy link
Contributor

subfuzion commented Aug 9, 2016

Add an rpc service for querying logs stored in elasticsearch. Provide support for queries with various filter criteria. Provide a cli logs command for querying the service.

Our concept of log collation corresponds to Docker Cloud's log multiplexing and is very similar to the work that @generalhenry worked on with amp-log-service. @freignat91 will be working on the log producer side and adding the cli interface for it (see #15). See Docker Cloud's docs for comparison (we intend to provide range queries, filtering, etc).

@subfuzion
Copy link
Contributor Author

subfuzion commented Aug 23, 2016

@bertrand-quenin You're getting very close with the basic log service. Please use the cmd/amp/cli package for any CLI-side command helpers; the api/client package shouldn't be aware of anything that has to do with parsing command line options (it should simply take parameters that it needs to do its work). Also, you can move the Logs function out of api/client/amp.go and put it in its own command helper, like api/client/logs.go.

Go ahead and start adding the log stream support as well that we've been discussing in the Observability document on Google Drive. The goal is to be able to start a service with a few replicas and be able to get access to a multiplexed log stream from the CLI. You should be able to automate testing based on capturing one of the existing swarm services.

Please don't forget to remove the code we don't need right now per this comment.

@subfuzion
Copy link
Contributor Author

@bertrand-quenin Thanks for a nice job. I'm going to close this issue now. We can open new issues for specific enhancements, etc.

@subfuzion subfuzion added this to the 0.1.0 milestone Oct 20, 2016
@subfuzion subfuzion modified the milestone: 0.1.0 Oct 25, 2016
@ingo ingo unassigned bquenin Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants