Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp service create #177

Merged
merged 1 commit into from
Sep 15, 2016
Merged

amp service create #177

merged 1 commit into from
Sep 15, 2016

Conversation

subfuzion
Copy link
Contributor

Adds ability to run service.

Verification

$ docker service create --name pinger appcelerator/pinger
# verify service ID 
$ docker service ls <id>
$ amp logs --service-name pinger
# verify log entry: `Server: localhost:50101`

cleanup

$ docker service rm pinger

freignat91
freignat91 approved these changes Sep 15, 2016
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

generalhenry
generalhenry reviewed Sep 15, 2016
View reviewed changes
api/rpc/service/service.go
"golang.org/x/net/context"
)

var (
// https://docs.docker.com/engine/reference/api/docker_remote_api/
// `docker version` -> Server API version => Docker 1.12x
defaultVersion = "v1.25"
defaultVersion = "1.24"
defaultHeaders = map[string]string{"User-Agent": "engine-api-cli-1.0"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not the engine api cli (should be amplifier imo)

Copy link
Contributor Author

@subfuzion subfuzion Sep 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, was going to update it. Rushed this for @freignat91. Will get this on the next PR.

@freignat91 freignat91 merged commit 26eefa2 into master Sep 15, 2016
@freignat91 freignat91 deleted the basic-service branch September 15, 2016 21:58
@subfuzion subfuzion mentioned this pull request Sep 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry left review comments

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subfuzion @generalhenry @freignat91