Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd to swarm #2

Merged
merged 3 commits into from
Aug 4, 2016
Merged

Add etcd to swarm #2

merged 3 commits into from
Aug 4, 2016

Conversation

subfuzion
Copy link
Contributor

Closes https://github.com/appcelerator/amp-project/issues/330

This PR adds etcd to the swarm script.

Verification:

$ docker run --rm --net=host -e ETCDCTL_API=3 quay.io/coreos/etcd:v3.0.4 etcdctl put foo bar
OK
$ docker run --rm --net=host -e ETCDCTL_API=3 quay.io/coreos/etcd:v3.0.4 etcdctl get foo
bar

@freignat91
Copy link
Contributor

it's ok, but it misses
--label amp.swarm="infrastructure"
for etct, otherwise the remove function won't remove it

@subfuzion
Copy link
Contributor Author

Thanks, good catch!

@subfuzion
Copy link
Contributor Author

How ironic for me to forget that. Ok, label is added.

@freignat91
Copy link
Contributor

tests ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants