Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack rollback on error #226

Merged
merged 1 commit into from
Sep 21, 2016
Merged

stack rollback on error #226

merged 1 commit into from
Sep 21, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Sep 21, 2016 •
edited by subfuzion
Loading

Rollback stack on error when bringing it up

prerequisite:

  • have a [stack yaml file] with a service publishing a port

test:

  • amp stack up test1 -f [stack yaml file]

The stack test1 is created

  • amp stack up test2 -f [stack yaml file]

The stack test2 should failed because use the same port is published, then the test2 stack creation is rollbacked

  • amp stack ls

Shows only the stack test1

chrisccoy
chrisccoy approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@chrisccoy chrisccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed as expected 👍

@chrisccoy chrisccoy merged commit 9878093 into master Sep 21, 2016
@chrisccoy chrisccoy deleted the stack-issue branch September 21, 2016 22:52
@subfuzion subfuzion changed the title stack rollback fixe issue stack rollback on error Oct 20, 2016
@subfuzion subfuzion added this to the 0.1.1 milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisccoy chrisccoy chrisccoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @chrisccoy @subfuzion