Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stack-id and stack-name as labels in containers #237

Merged
merged 1 commit into from
Sep 23, 2016
Merged

add stack-id and stack-name as labels in containers #237

merged 1 commit into from
Sep 23, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Sep 23, 2016 •
edited
Loading

related to #232
add stack id and stack name as labels in container to allow amp-agent to add them in logs

test:

  • make, start swam amp
  • create a stack: amp stack up test -f [stack file]
  • verify using docker inspect than containers created for stack services have labels: io.amp.stack.id and io.amp.stack.name

regression tests: make test

@freignat91 freignat91 mentioned this pull request Sep 23, 2016
Closed
bquenin
bquenin approved these changes Sep 23, 2016
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working

@bquenin bquenin merged commit 2dd6ddf into master Sep 23, 2016
@bquenin bquenin deleted the stack-log branch September 23, 2016 16:34
@subfuzion subfuzion added this to the 0.1.1 milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @bquenin @subfuzion