Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service network attachment #266

Merged
merged 1 commit into from
Sep 30, 2016
Merged

add service network attachment #266

merged 1 commit into from
Sep 30, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Sep 29, 2016 •
edited
Loading

#239 stage one preparation

add service networks attachment

test:

  • launch amp
  • create a service attached to the network "amp-swarm" with two aliases: "essai1 and "essai2":
  • amp service create appcelerator/pinger:latest --name essai --network amp-swarm:essai1:essai2
  • inspect the service essai container to verify that the amp-swarm network is well in the Networks container setting
  • Verify using amp-agent (which is on amp-swarm also) than essai service is visible:
  • docker exec -it [amp-agent container id] sh
  • ping essai: returns a valid IP address
  • ping essai1: returns the same IP
  • ping essai2: returns the same IP
  • ping essai3: returns dns error, invalid address

regression test:

  • make test

@freignat91 freignat91 changed the title add service network appcelerator/amp#239 add service network attachment Sep 29, 2016
subfuzion
subfuzion approved these changes Sep 30, 2016
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @freignat91. Looks good and tests pass. 👍

@subfuzion subfuzion merged commit 3dc3005 into master Sep 30, 2016
@subfuzion subfuzion deleted the service-network branch September 30, 2016 04:17
hadrien-gantzer pushed a commit that referenced this pull request Oct 4, 2016
@freignat91 @hadrien-gantzer
add service network #239 (#266)
6122125
@subfuzion subfuzion added this to the 0.1.1 milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@freignat91 @subfuzion