Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats issue 402 (2) #404

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Fix stats issue 402 (2) #404

merged 1 commit into from
Nov 3, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Nov 2, 2016 •
edited
Loading

Related to #402
Fix stats issue, service-name filter regression

test:

  • start amp: ./swarm start
  • start local amplifier
  • execute: amp stats --service-name amp

Display only the services starting by 'amp'

regression tests:

  • make test

generalhenry
generalhenry approved these changes Nov 2, 2016
View reviewed changes
Copy link
Contributor

@generalhenry generalhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed issue and fix locally

@subfuzion
Copy link
Contributor

LGTM

@subfuzion subfuzion merged commit 4c7d2da into master Nov 3, 2016
@subfuzion subfuzion deleted the fix-stats-402 branch November 3, 2016 19:07
@freignat91 freignat91 added this to the 0.3.0 milestone Nov 7, 2016
@ndegory ndegory changed the title fix stats issue 402 Fix stats issue 402 (2) Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @subfuzion @generalhenry