Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RPC tests #416

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Refactor RPC tests #416

merged 1 commit into from
Nov 4, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Nov 4, 2016

Related to #410 and #301
This PR is a proposal (from Nicolas and me) presented in Mobilize topic: "Integration tests automation"

It groups all rpc tests in the api/rpc/tests folder and allow to execute them launching amplifier only one time.
Unitary tests and integration tests have been separated

  • unitary tests stays in their own package
  • integrations tests have been moved (and refactor) in ./api/rpc/tests

test:

  • execute all integration tests: go test -v ./api/rpc/tests
  • execute only Stack integration tests: go test -v ./api/rpc/tests -run TestStack
    same with:
  • TestLogs
  • TestTopic
  • TestStats
  • TestService

Then it's the base to be able to use them in a dedicated service (not in this PR) and so to be able to execute them in any swarm environments.

regression tests:

  • make test (execute all integration and unitary tests)

Copy link
Contributor

@ndegory ndegory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would help to be able to run the tests on a multi node environment

@generalhenry generalhenry merged commit 35f66c1 into master Nov 4, 2016
@generalhenry generalhenry deleted the test-in-one branch November 4, 2016 18:03
@freignat91 freignat91 added this to the 0.3.0 milestone Nov 7, 2016
@subfuzion subfuzion changed the title refactor rpc tests Refactor RPC tests Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants