Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amp config get and set #420

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Add amp config get and set #420

merged 1 commit into from
Nov 7, 2016

Conversation

generalhenry
Copy link
Contributor

closes #401

Adds amp config <field> as a getter and amp config <field> <value> as a setter

To test:
amp config serverAddress
amp config serverAddress localhost:8080
amp config serverAddress
amp stack ls

subfuzion
subfuzion approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixed merge conflicts, glide update forced updating Docker ServiceListOptions usage.

@subfuzion subfuzion merged commit 06f31cd into master Nov 7, 2016
@subfuzion subfuzion deleted the config-get-set branch November 7, 2016 15:48
@generalhenry generalhenry added this to the 0.3.0 milestone Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

amp config (get/set)
2 participants
@generalhenry @subfuzion