Added timeout, retry and delay in CLI tests #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalhenry
reviewed
Nov 5, 2016
| @@ -5,6 +5,8 @@ | |||
| options: | |||
| - | |||
| expectation: logs-all | |||
| timeout: | |||
There was a problem hiding this comment.
Are empty entries needed?
There was a problem hiding this comment.
removed the empty entries
neha-viswanathan
force-pushed
the
cli-test-timeout
branch
from
3171cbc to
4c58d9a
Compare
generalhenry
approved these changes
Nov 5, 2016
|
@neha-viswanathan Please rebase with master and resolve the conflict in |
neha-viswanathan
force-pushed
the
cli-test-timeout
branch
from
4c58d9a to
03b5ad1
Compare
ndegory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout, delay and retry fields in the yaml files. No values added as expected timeouts are not know.
The tests pass as the expectation field for remove service command has no regex (Ref: #413)
To test -
go test github.com/appcelerator/amp/cmd/amp/cli