Templating for generating random ports (part 2) #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subfuzion
reviewed
Nov 10, 2016
| endTime := time.Now().UnixNano() / 1000000 | ||
| if cmdSpec.Timeout != 0 && endTime-startTime >= cmdSpec.Timeout { | ||
| endTime := time.Since(startTime) | ||
| if cmdSpec.Timeout != 0 && int64(endTime/time.Millisecond) >= cmdSpec.Timeout { |
There was a problem hiding this comment.
See this example on how to use a channel for executing code after a timeout to kill the process and synchronize on the success or failure path before returning.
| @@ -117,16 +117,15 @@ func runTestSpec(t *testing.T, test *TestSpec) (err error) { | |||
|
|
|||
| for _, cmdSpec := range test.Commands { | |||
| var tmplString []string | |||
| startTime := time.Now().UnixNano() / 1000000 | |||
| startTime := time.Now() | |||
|
|
|||
| for i = -1; i < cmdSpec.Retry; i++ { | |||
| err = nil | |||
There was a problem hiding this comment.
Can move err to the loop initializer (if you really need it).
JosephGJ
force-pushed
the
cli-test-port-randomiser
branch
2 times, most recently
from
56c36a8 to
2333d89
Compare
generalhenry
approved these changes
Nov 14, 2016
* Implementation of contexts for timeouts * Refactoring to include #451 changes
JosephGJ
force-pushed
the
cli-test-port-randomiser
branch
from
2333d89 to
6b17753
Compare
generalhenry
approved these changes
Nov 14, 2016
ndegory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #441 merged before necessary changes made.
Changes:
time.Since()function usedto test
go test -v ./cmd/amp/clifor testing timing changes, modify
stack.ymlfirst commandamp stack upto a failing case, as it can test the retry and timeout fields, then run.go test -v ./cmd/amp/cli