add cmd color themes #495
Merged
add cmd color themes #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndegory
reviewed
Nov 23, 2016
|
|
||
| func (s *ampManager) setColors() { | ||
| theme := s.getTheme() | ||
| if theme == "white" { |
There was a problem hiding this comment.
I think the name of the theme should not be based on one of the color of the theme, but should match the terminal theme on which it displays best.
So here white should be black.
There was a problem hiding this comment.
done, renamed "dark", PR description updated too
freignat91
force-pushed
the
cmd-theme
branch
3 times, most recently
from
91580a6 to
1c38d73
Compare
| if err != nil { | ||
| return "" | ||
| } | ||
| file, err := os.Open(path.Join(homedir, ".amp.yaml")) |
There was a problem hiding this comment.
why manually check the config?
There was a problem hiding this comment.
yes, you're right, i updated the code to use the regular amp config
freignat91
force-pushed
the
cmd-theme
branch
from
dec43ea to
5ce0386
Compare
|
You can also do |
generalhenry
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #477
Have amp commands color themes to adapt colors to different terminals L&F.
Default is the "magenta" theme created by Neha, but it doesn't look good on Ubuntu default terminal which are magenta dark by default.
Added one named "dark" to be back to the original colors (white in place of magenta)
to change it, update $HOME/.amp.yaml file adding this line for instance:
cmdTheme: dark
For now only 2 themes (default or dark)
Test:
It's possible to add new theme updating cmd/amp/platform_manager.go