Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix amp start -f panic #533

Merged
merged 1 commit into from
Dec 9, 2016
Merged

fix amp start -f panic #533

merged 1 commit into from
Dec 9, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Dec 9, 2016 •
edited
Loading

Fix the #532

it's not easy to reproduce the same error condition, to do so

  • make install
  • start a service, not an infrastructure one
  • remove its image or not (both cases can be tested)
  • start amp -f (if amp is not alreday started)
  • restart amp force mode: amp pf start -f
  • you don't got panic anymore.

ndegory
ndegory approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@ndegory ndegory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing on Mac OS

@ndegory ndegory added this to the 0.4.0 milestone Dec 9, 2016
@ndegory ndegory merged commit c97190f into master Dec 9, 2016
@ndegory ndegory deleted the fix-532 branch December 9, 2016 13:11
@ndegory ndegory changed the title fix 532 fix amp start -f panic Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegory ndegory ndegory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@freignat91 @ndegory