Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AMP stats panic #534

Merged
merged 2 commits into from
Dec 9, 2016
Merged

fix AMP stats panic #534

merged 2 commits into from
Dec 9, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Dec 9, 2016 •
edited by bquenin
Loading

Fix #531

test:

  • ./shrink.sh local
  • make install
  • amp pf start --local -f
  • make test

@ndegory ndegory added this to the 0.4.0 milestone Dec 9, 2016
@ndegory ndegory changed the title fix 531 fix AMP stats panic Dec 9, 2016
@bquenin bquenin self-assigned this Dec 9, 2016
bquenin
bquenin approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a while, but I think it's good now

@ndegory ndegory self-requested a review December 9, 2016 18:41
ndegory
ndegory approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@ndegory ndegory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing on Mac OS

Dockerfile
@@ -1,5 +1,5 @@
# appcelerator/protoc is based on alpine and includes latest go and protoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove that comment, it doesn't apply anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

JosephGJ
JosephGJ approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@JosephGJ JosephGJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndegory ndegory merged commit 3b79522 into master Dec 9, 2016
@bquenin bquenin deleted the fix-531 branch December 9, 2016 19:10
ndegory added a commit that referenced this pull request Dec 16, 2016
@ndegory
revert pqrt of #534, protoc image is needed for image build
78928ba
subfuzion pushed a commit that referenced this pull request Dec 16, 2016
@ndegory @subfuzion
Optimize development workflow (#595)
eb991b4 
* build image part of Makefile #553

* developer workflow improvement (#562)

* revert pqrt of #534, protoc image is needed for image build
@ingo ingo unassigned bquenin Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

@ndegory ndegory ndegory approved these changes

@JosephGJ JosephGJ JosephGJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@freignat91 @bquenin @ndegory @JosephGJ