-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverless prototype #539
Serverless prototype #539
Conversation
2fad9c1
to
1819f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests executed ok
It would be nice if you could use [function-ident] in place of [function-id] I would also prefer fn.local.atomiq.io (or the like) to localhost:4242 (aka add it to the haproxy config) |
One more small thing, |
@generalhenry You're right about the URL, this is only temporary. It should definitely be something like |
1819f11
to
31e08c0
Compare
31e08c0
to
ac0930a
Compare
|
Maybe this issue has an impact as well: moby/moby#29421 |
dfb147a
to
ecf004e
Compare
@bquenin docker 1.12.5 has been released, which contains moby/moby#29424 to resolve the issue you linked to; https://github.com/docker/docker/releases/tag/v1.12.5 |
@thaJeztah thanks for the feedback. Just tested it with 1.12.5 and now it works like a charm! |
Thanks @thaJeztah. I would imagine this will land shortly in the next 1.13 RC as well then (we're currently on v1.13.0-rc3). |
@subfuzion looks like the fix was actually in 1.13.0-rc2 already (see moby/moby#28674); are you having this problem on RC3? |
@thaJeztah I tested on latest stable (1.12.5). Going to check on 1.13.0-rc3. |
Perfect! If you have problems on 1.13, please open an issue in the issue tracker 👍 |
@thaJeztah Just tested it a thousand times on 1.13.0-rc3, works fine as well! Thanks again |
Thanks for testing! |
83e1192
to
7c3f539
Compare
@bquenin Very nice! I'm merging this into v0.5.0-rc1 for additional evaluation. 👍 |
@bquenin It looks like there are a few conflicts due to @freignat91 / @ndegory cluster management PR that I just merged into v0.5.0-rc1. Can you work to resolve asap? Thanks! |
7c3f539
to
b97dff3
Compare
@subfuzion Ok, I rebased on the branch v0.5.0-rc1 |
* commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * serverless prototype (#539) * Amp cleanup (#603) * Fix for issues #547,#561,#565 * minor cleanup * commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * serverless prototype (#539) * Amp version more useful info
* commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * serverless prototype (#539) * commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * Revert "Amp version command - more useful info" (#611) * Add functions to the ui (#605) * KV ui (#606) * Add functions to the ui * add kv to ui * bump version to 0.6.0-dev * Added amp help command (#652) * Included Long message in help command output * remerge version
* commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * serverless prototype (#539) * commit server,agents,clients, AMP Bootstrap and fixes reports (#519) * add bootstrap feature to AMP cluster CLI (#306) * update vendors (huge diff) * Revert "Amp version command - more useful info" (#611) * Add functions to the ui (#605) * KV ui (#606) * Add functions to the ui * add kv to ui * bump version to 0.6.0-dev * Added amp help command (#652) * Included Long message in help command output * remerge version
Related to #521
Verification
CLI tests
The source code of the
amp-demo-function
is available here: amp-demo-function