Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-572: grpc codes error for topic #584

Merged
merged 1 commit into from
Dec 15, 2016
Merged

issue-572: grpc codes error for topic #584

merged 1 commit into from
Dec 15, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Dec 14, 2016 •
edited
Loading

related to #572
add grpc errors for topic

test:

make install
../shrink.sh local
amp pf start -v --local
make test

rules applies for all grpc error issues to be consistent:

  • if docker error: code.Internal
  • If ETCD creation/update/delete error: code.Internal
  • if state machine creation failed: code.Internal
  • if state machine inconstancy: code.FailedPrecondition
  • if stack file error or arg error: code.InvalidArgument
  • if internal timeout: code.DeadlineExceeded
  • if resource not found: code.NotFound
  • if resource creation already exist: code.AlreadyExists

@freignat91 freignat91 changed the title issue-572 issue-572: grpc codes error for topic Dec 14, 2016
generalhenry
generalhenry approved these changes Dec 14, 2016
View reviewed changes
Copy link
Contributor

@generalhenry generalhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://amplifier-api.local.appcelerator.io/v1/topic Failed to load resource: the server responded with a status of 409 (Conflict) :)

@subfuzion
Copy link
Contributor

LGTM 👍

@subfuzion subfuzion merged commit 24ada28 into master Dec 15, 2016
@subfuzion subfuzion deleted the issue-578 branch December 15, 2016 15:56
@generalhenry generalhenry mentioned this pull request Dec 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @subfuzion @generalhenry