Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 575: grpc codes error for logs #586

Merged
merged 1 commit into from
Dec 15, 2016
Merged

issue 575: grpc codes error for logs #586

merged 1 commit into from
Dec 15, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Dec 14, 2016 •
edited
Loading

related to #575
add grpc errors for logs

test:

make install
../shrink.sh local
amp pf start -v --local
make test

rules applies for all grpc error issues to be consistent:

  • if docker error: code.Internal
  • If ETCD creation/update/delete error: code.Internal
  • if state machine creation failed: code.Internal
  • if state machine inconstancy: code.FailedPrecondition
  • if stack file error or arg error: code.InvalidArgument
  • if internal timeout: code.DeadlineExceeded
  • if resource not found: code.NotFound
  • if resource creation already exist: code.AlreadyExists

@freignat91 freignat91 changed the title issue 575 issue 575: grpc codes error for logs Dec 14, 2016
subfuzion
subfuzion approved these changes Dec 15, 2016
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subfuzion subfuzion merged commit b311a07 into master Dec 15, 2016
@subfuzion subfuzion deleted the issue-575 branch December 15, 2016 15:58
@bquenin bquenin added this to the 0.4.0 milestone Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
area/api kind/enhancement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@freignat91 @subfuzion @bquenin