Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration file location in ~/.config/amp/ #592

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Configuration file location in ~/.config/amp/ #592

merged 1 commit into from
Dec 15, 2016

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Dec 15, 2016 •
edited
Loading

resolves #560 and #556

  • compliant with XDG base directory configuration specifications
  • prettier output for amp config

How to test:

  • make install
  • touch ~/.amp.yaml && amp config # should complain
  • rm ~/.amp.yaml
  • amp config # displays default configuration in a pretty format
  • amp config ServerAddress # displays the server address, something like 127.0.0.1:8080
  • amp config ServerAddress amp.gov.us:8080 # displays the value
  • amp config ServerAddress # displays the value set above
  • cat ~/.config/amp/amp.yaml # contains the configuration, in particular the value set above

@ndegory
Copy link
Contributor Author

ndegory commented Dec 15, 2016

tests on Mac OS ✅

@ndegory ndegory added this to the 0.4.0 milestone Dec 15, 2016
This was referenced Dec 15, 2016
Closed
Closed
subfuzion
subfuzion approved these changes Dec 15, 2016
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

@subfuzion subfuzion merged commit 71c6967 into master Dec 15, 2016
@subfuzion subfuzion deleted the issue-560 branch December 15, 2016 16:26
@ndegory ndegory changed the title WIP: Configuration file location in ~/.config/amp/ Configuration file location in ~/.config/amp/ Dec 19, 2016
@ndegory ndegory mentioned this pull request Dec 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
area/cli
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

config files location
2 participants
@ndegory @subfuzion