Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] moved amp confighelper #613

Merged
merged 2 commits into from
Jan 3, 2017
Merged

[refactor] moved amp confighelper #613

merged 2 commits into from
Jan 3, 2017

Conversation

subfuzion
Copy link
Contributor

Moved amp/confighelper to amp/cli/confighelper, and moved the SaveConfiguration function that was in amp/cli/cli to match up with the InitFunction.

Verification

$ make install-cli
$ amp config # should display config
$ amp config Verbose true
$ amp config Verbose # verify true
$ amp config Verbose false
$ amp config Verbose # verify false

@subfuzion subfuzion changed the title moved amp confighelper [refactor] moved amp confighelper Dec 30, 2016
generalhenry
generalhenry reviewed Jan 2, 2017
View reviewed changes
cmd/amp/main.go
@@ -67,7 +67,7 @@ func main() {
}
AMP = client.NewAMP(Config)
if AMP.Verbose() == false {
RootCmd.SilenceErrors = true
;RootCmd.SilenceErrors = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray semi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, missed this here, actually fixed it in a subsequent PR, though. Anyway, will fix here, thanks.

freignat91
freignat91 approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, then configHelper is now importable and could be used also by ampadm.
I'll suppress the specific apmadm confighelpter to use this one in another PR

@freignat91 freignat91 merged commit 048480d into master Jan 3, 2017
@freignat91 freignat91 deleted the refactor01-move-confighelper branch January 3, 2017 13:18
@bquenin bquenin modified the milestone: 0.5.0 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry left review comments

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
area/cli kind/refactor
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@subfuzion @generalhenry @freignat91 @bquenin