Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] client logging #616

Merged
merged 5 commits into from
Jan 3, 2017
Merged

[refactor] client logging #616

merged 5 commits into from
Jan 3, 2017

Conversation

subfuzion
Copy link
Contributor

Refactored to use a Logger interface for api/client/amp implemented by the actual client (cli) that also supports the grpclog.Logger interface as well. The cli provides a simple logger implementation at cmd/amp/cli/logger.

bquenin
bquenin approved these changes Jan 2, 2017
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

freignat91
freignat91 approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freignat91 freignat91 merged commit f4ad911 into master Jan 3, 2017
@freignat91 freignat91 deleted the refactor04-client-logging branch January 3, 2017 13:55
@bquenin bquenin modified the milestone: 0.5.0 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
area/cli kind/enhancement
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@subfuzion @bquenin @freignat91