Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent amp logs from crashing when Verbose flag is set #630

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Prevent amp logs from crashing when Verbose flag is set #630

merged 1 commit into from
Jan 3, 2017

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Jan 3, 2017

Fix #629

Verification

$ make install
$ make TAG=local build-image
$ amp pf pull
$ amp pf start --local
$ amp config Verbose true
$ amp logs

Should not crash

@bquenin bquenin added this to the 0.5.0 milestone Jan 3, 2017
freignat91
freignat91 approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested ok

@freignat91 freignat91 merged commit ff44db3 into master Jan 3, 2017
@freignat91 freignat91 deleted the fix-amp-logs-verbose branch January 3, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
area/cli kind/bug
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bquenin @freignat91