Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'amp log -f' first working implementation #66

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Aug 25, 2016

#11

In order to test this PR:

./swarm stop
./swarm pull
./swarm start --min

In order to circumvent an issue (#69) in accessing kafka from amplifier, you need add kafka container hostname to your machine /etc/host.

Getting kafka hostname:

docker ps
docker inspect kafka_container_id | grep hostname
sudo cat /var/lib/docker/containers/a4424bcafbab110b67922994243aca15fc57ab3422fdec21f7460fe16b024456/hostname

Update /etc/hosts in order to assign 127.0.0.1 to kafka hostname:

127.0.0.1   localhost a4424bcafbab

Then test as follows:

make
amplifier
amp logs --f
amp logs --f --short

@subfuzion
Copy link
Contributor

@bertrand-quenin Just letting you know I'll go ahead and resolve the conflicts so we can get the PR merged asap.

@subfuzion
Copy link
Contributor

subfuzion commented Aug 25, 2016

You can also run ./swarm restart --min to do the same as the three steps in the description.

@subfuzion
Copy link
Contributor

This is all you need to do to get the hostname for now (researching if there's a better way):

docker ps --filter "name=kafka\." --format '{{ .ID }}'

I explain it in more detail here: #69 (comment).

@subfuzion
Copy link
Contributor

subfuzion commented Aug 25, 2016

Rebased on master.

@subfuzion
Copy link
Contributor

Very nice, the streaming works well. I would like to make a few changes with the flags you created, but I don't want to hold up this PR. We can tackle those changes later.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants