Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for log stream #67

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Filtering for log stream #67

merged 1 commit into from
Aug 26, 2016

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Aug 25, 2016

#11

In order to test this PR:

./swarm stop
./swarm pull
./swarm start --min

In order to circumvent an issue (#69) in accessing kafka from amplifier, you need add kafka container hostname to your machine /etc/host.

Getting kafka hostname:

docker ps
docker inspect kafka_container_id | grep hostname
sudo cat /var/lib/docker/containers/a4424bcafbab110b67922994243aca15fc57ab3422fdec21f7460fe16b024456/hostname

Update /etc/hosts in order to assign 127.0.0.1 to kafka hostname:

127.0.0.1   localhost a4424bcafbab

Then test as follows:

make
amplifier
amp logs --f
amp logs --f --short

@subfuzion
Copy link
Contributor

@bertrand-quenin Just letting you know I'll go ahead and resolve the conflicts so we can get the PR merged asap.

@subfuzion
Copy link
Contributor

subfuzion commented Aug 26, 2016

Testing notes:

Swarm can be stopped, updated, and restarted with ./swarm restart --min.

Kafka hostname can be obtained with: docker ps --filter "name=kafka\." --format '{{ .ID }}'.

Start server with auth keys: amplifier --clientid=<id> --clientsecret=<secret>.

Flags are now -f, --follow, -s, --short.

@subfuzion subfuzion force-pushed the 11-stream-filtering branch from 1fc889d to cc4427c Compare August 26, 2016 03:12
@subfuzion
Copy link
Contributor

Rebased, resolved conflicts, and squashed. The rest looks good, nice work @bertrand-quenin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants