Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): fix incorrect k8s locations due to JSON to YAML conversion #8073

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(misconf): fix incorrect k8s locations due to JSON to YAML conversion #8073

wants to merge 2 commits into from

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Dec 9, 2024 •
edited
Loading

Description

This PR uses github.com/go-json-experiment/json to parsing JSON manifests, which produces correct node positions, unlike the current approach where JSON is first converted to YAML and then parsed.

Before

AVD-KSV-0021 (LOW): Container 'hello' of Pod 'hello-cpu-limit' should set 'securityContext.runAsGroup' > 10000
════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Force the container to run with group ID > 10000 to avoid conflicts with the host’s user table.

See https://avd.aquasec.com/misconfig/ksv021
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 test.json:7-12
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   7 ┌     "spec": {
   8 │         "containers": [
   9 │             {
  10 │                 "command": ["sh", "-c", "echo 'Hello' && sleep 1h"],
  11 │                 "image": "busybox",
  12 └                 "name": "hello"
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

After

AVD-KSV-0021 (LOW): Container 'hello' of Pod 'hello-cpu-limit' should set 'securityContext.runAsGroup' > 10000
════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Force the container to run with group ID > 10000 to avoid conflicts with the host’s user table.

See https://avd.aquasec.com/misconfig/ksv021
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 test.json:8-13
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   8 ┌         "containers": [
   9 │             {
  10 │                 "command": ["sh", "-c", "echo 'Hello' && sleep 1h"],
  11 │                 "image": "busybox",
  12 │                 "name": "hello"
  13 └             }
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin mentioned this pull request Jan 28, 2025
Open
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 8, 2025
@nikpivkin
Copy link
Contributor Author

@simar7 Although this is an experimental package, it is already used in a lot of projects. Also recently opened a proposal to include this package in Go as encoding/json/v2. What do you think about using it?

@nikpivkin nikpivkin marked this pull request as ready for review February 19, 2025 19:32
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(misconf): Incorrect location of findings in k8s JSON scan
1 participant
@nikpivkin