fix(report): handle [email protected] schema for misconfigs in sarif report #8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ricardo Perez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
2 tasks
simar7
reviewed
Feb 13, 2025
Comment on lines
+360
to
+366
| case strings.HasPrefix(s, "[email protected]:"): | ||
| // build bitbucket url format | ||
| // e.g. `[email protected]:terraform-aws-modules/terraform-aws-s3-bucket.git?ref=v4.2.0/main.tf` -> `bitbucket.org/terraform-aws-modules/terraform-aws-s3-bucket/src/v4.2.0/main.tf` | ||
| // cf. https://github.com/aquasecurity/trivy/issues/8154 | ||
| s = strings.ReplaceAll(s, "[email protected]:", "bitbucket.org/") | ||
| s = strings.ReplaceAll(s, ".git", "") | ||
| s = strings.ReplaceAll(s, "?ref=", "/src/") |
There was a problem hiding this comment.
Maybe we can refactor this logic out into a function as it's also repeated with GitHub?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overwrite [email protected] schema for misconfigs in sarif report.
Related issues
Related PRs
[email protected]schema for misconfigs insarifreport #7898Checklist