Adding patches to kustomize requires that the kustomization file have a .yaml extension

[mattrasband]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Kustomize allows a couple different file names for the kustomization file. If the patches option is included in the kustomization section of an appset file the only allowed filename is kustomization.yaml, causing previously working deployments to break.

To Reproduce

1. Have a kustomization.yml file for a project pointed to by argoproj.io/v1alpha1.Application without a patches key under spec.source.kustomize.
2. Add a patch, the error you get is something akin to code = Unknown desc = Manifest generation error (cached): failed to load kustomization.yaml
3. Rename your kustomization.yml from item 1 to kustomization.yaml
4. Profit

Expected behavior

There should not be any required changes to the file name when introducing supported features.

Screenshots

Version

v2.11.5+c4b283c

Logs

Paste any relevant application logs here.

Here are the relevant files:

• argo-cd/util/kustomize/kustomize.go

  Line 259 in feb7097

  kustomizationPath := filepath.Join(k.path, "kustomization.yaml")

• argo-cd/util/kustomize/kustomize.go

  Line 392 in feb7097

  var KustomizationNames = []string{"kustomization.yaml", "kustomization.yml", "Kustomization"}

[mattrasband]

It's worth noting that there is a workaround to avoid bumping versions when this is fixed: simply rename kustomzation.yml/Kustomization to kustomization.yaml

[crenshaw-dev]

We should borrow code from Kustomize to make sure that our file extension handling matches theirs. https://github.com/kubernetes-sigs/kustomize/blob/447a60903cd142948443a6bd441b2749ad643815/api/konfig/general.go#L12

[crenshaw-dev]

This is probably the exact function we need: https://github.com/kubernetes-sigs/kustomize/blob/447a60903cd142948443a6bd441b2749ad643815/api/internal/target/kusttarget.go#L100

[nitishfy]

I'd like to take this up.

[mattrasband]

I'd like to take this up.

Sounds good @nitishfy - let me know if you change your mind.