Autoscaler worker instances are named the same as the gitlab-runner agent instance

[abeluck]

terraform-aws-gitlab-runner/docker_autoscaler.tf

Lines 96 to 109 in 6f684d3

	tag_specifications {
	resource_type = "instance"
	tags = local.tags
	}
	tag_specifications {
	resource_type = "volume"
	tags = local.tags
	}
	tag_specifications {
	resource_type = "network-interface"
	tags = local.tags
	}
	tags = local.tags

This code ensures that the gitlab-runner instance always has the same name as the worker instances, which is not desirable and contradicts the docs.

It should be possible to have the autoscaler worker instances have different names/tags than the agent instance itself.

[kayman-mk]

Arrgh, I can't check it here as I still have the docker-machine running. The last time I tried the autoscaler, I was quickly rate limited by AWS.

[abeluck]

autoscaler has been working well for us since November. Though we only ever have 10-15 worker instances running at a time.