Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the newer gitlab authentication token the SSM parameter should not be created by this module #1225

Open
abeluck opened this issue Jan 15, 2025 · 0 comments

Comments

@abeluck
Copy link

abeluck commented Jan 15, 2025

resource "aws_ssm_parameter" "runner_registration_token" {
name = local.secure_parameter_store_runner_token_key
type = "SecureString"
value = "null"
key_id = local.kms_key_arn
tags = local.tags
lifecycle {
ignore_changes = [value]
}
}

When you want to use this (amazing!) module alongside gitlab_user_runner to create the runners in Gitlab, you will also want to provide your own aws_ssm_parameter resource containing the output of gitlab_user_runner.this.token as its value.

Passing that aws ssm param as the value to runner.gitlab.preregistered_runner_token_ssm_parameter_name works fine! However this module still creates the old parameter which is confusing and not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant