Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramalama serve is not checking if the port is available before running the command #797

Open
benoitf opened this issue Feb 12, 2025 · 2 comments

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2025

Being a pretty dumb user, I don't care the port where the model will be served. It can be a random port as it's being displayed

  1. using 8080 as a default port is quite challenging because as a developer, I have tons of app that I start that are already using this port.
    (so picking up a port different than 8080 can increase the "first attempt succeed"

  2. most of the cli launchers detect that the port is in use and is serving the app using a basic '+1' on the default port

so If I launch 2 serve commands, it won't fail (unless I specify a port number and in that case yes I expect it fails if it's already taken but without specifying a port number I will assume the tool is picking one for me that works)

here is the current error message:

Error: preparing container ee6f2c8cd4377db38836b25c7523147a2383bcd9d86f22db0446b15212bd5bfb for attach: cannot listen on the TCP port: listen tcp4 :8080: bind: address already in use
@ericcurtin
Copy link
Collaborator

  1. makes sense to me, keep trying ports and increment until an available one is found

@rhatdan
Copy link
Member

rhatdan commented Feb 13, 2025

We would need to somehow display the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants