If the request already has the scope, don't fetchToken again #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuthorizeRequest() injects the 'pull' scope if `from` is set unconditionally. If the current token already has that scope, it will be inserted into the scope list twice and `addedScopes` will be set to true, resulting in a new token being fetched that has no net new scopes. Instead, check whether `additionalScopes` are actually new. Signed-off-by: Clayton Coleman <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 60.24% 50.63% -9.62%
==========================================
Files 126 126
Lines 14426 14433 +7
==========================================
- Hits 8691 7308 -1383
- Misses 4847 6377 +1530
+ Partials 888 748 -140
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthorizeRequest() injects the 'pull' scope if
fromis set unconditionally. If the current token already has that scope, it will be inserted into the scope list twice andaddedScopeswill be set totrue, resulting in a new token being fetched that has no net new scopes.
Instead, check whether
additionalScopesare actually new.Signed-off-by: Clayton Coleman [email protected]