Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonding LP token should require actually locking #1723

Open
omritoptix opened this issue Jan 27, 2025 · 1 comment
Open

Bonding LP token should require actually locking #1723

omritoptix opened this issue Jan 27, 2025 · 1 comment
Assignees
@keruch

Comments

@omritoptix
Copy link
Contributor

Currently we changed the rewards to be once a day (and not once a block like before) to prevent DOS. this introduces potential unfairness in terms of who's eligable for rewards.
@mtsitrin
Copy link
Contributor

mtsitrin commented Feb 10, 2025 •
edited
Loading

requires changes in x/incentives module:

  • auto perpetual gauge creation (currently created with 60s)
  • manual gauge creation
  • IRO pool creation

the module uses LockableDurations to store the "60s" value
we can overwrite it on the upgrade, or move it to params

need to think how to handle backward compatibility with the portal and existing gauges

we'll also need to create new perpetual gauges for the existing rollapp assets

@omritoptix omritoptix assigned keruch and unassigned mtsitrin Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keruch keruch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omritoptix @keruch @mtsitrin