Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jailer bind mounts integration test #1099

Open
alexandruag opened this issue May 17, 2019 · 1 comment · May be fixed by #5025
Open

Add jailer bind mounts integration test #1099

alexandruag opened this issue May 17, 2019 · 1 comment · May be fixed by #5025
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Parked Indicates that an issues or pull request will be revisited later Type: Enhancement Indicates new feature requests

Comments

@alexandruag
Copy link
Contributor

We should add an integration test to cover similar use cases as those mentioned in #1089. We can use this branch as a starting point, after harmonizing it with the latest version of #1093 (ideally by dropping the cherry picked commit at the end, and rebasing master after it gets merged).
@alexandruag alexandruag added the Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled label Jul 15, 2019
@alsrdn alsrdn added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` and removed Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled labels Feb 1, 2022
@JonathanWoollett-Light JonathanWoollett-Light added Type: Enhancement Indicates new feature requests and removed Feature: Jailing labels Mar 23, 2023
@ShadowCurse
Copy link
Contributor

To re-instantiate the requirements for this issue:
There was a PR #1093 that fixed the bind mounts propagation, but it did not add any tests for the fix. This issue is tracking the addition if such tests. Examples of jailer tests can be found here.

@ShadowCurse ShadowCurse added the Good first issue Indicates a good issue for first-time contributors label Apr 15, 2024
@zulinx86 zulinx86 added the Status: Parked Indicates that an issues or pull request will be revisited later label Jun 20, 2024
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 3, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation
68009ac
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 3, 2025
@anthonycorletti
test: firecracker-microvm#1099: make sure the vm is killed
b570b6b
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 3, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation
4cd1f46
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 4, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation
9be89df
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 4, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation
df5cd9a
@anthonycorletti anthonycorletti linked a pull request Feb 4, 2025 that will close this issue
Open
10 tasks
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 11, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation
bdc9f07
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 11, 2025
@anthonycorletti
test: firecracker-microvm#1099 jailer mount propagation Signed-off-by…
2fea612 
…: Anthony Corletti <[email protected]>
anthonycorletti added a commit to anthonycorletti/firecracker that referenced this issue Feb 11, 2025
@anthonycorletti
test: closes firecracker-microvm#1099 jailer mount propagation by cre…
6940c7f 
…ating mounts for the guest kernel and rootfs and mounting them to the jailer root as mentioned in firecracker-microvm#1089 Signed-off-by: Anthony Corletti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Parked Indicates that an issues or pull request will be revisited later Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test jailer bindmounts to root anthonycorletti/firecracker
5 participants
@alexandruag @JonathanWoollett-Light @ShadowCurse @zulinx86 @alsrdn