Iseyer/replicate tags #21660
Open
Iseyer/replicate tags #21660
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianseyer
force-pushed
the
iseyer/replicate-tags
branch
2 times, most recently
from
548afb9 to
ba628f6
Compare
Signed-off-by: ianseyer <[email protected]> Signed-off-by: ianseyer <[email protected]>
ianseyer
force-pushed
the
iseyer/replicate-tags
branch
from
ba628f6 to
634b662
Compare
|
@Vad1mo @wy65701436 @reasonerjt if you would be so kind as to review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21660 +/- ##
==========================================
+ Coverage 45.36% 46.30% +0.93%
==========================================
Files 244 249 +5
Lines 13333 14047 +714
Branches 2719 2897 +178
==========================================
+ Hits 6049 6504 +455
- Misses 6983 7199 +216
- Partials 301 344 +43
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, harbor does not replicate image tags for event-based replications. Instead, if a new tag is pushed, a replication event is not fired.
This issue is easily replicated:
There should be followup work to correct the issue of webhooks not being fired for tags being created.
Issue being fixed
Fixes #21623
Please indicate you've done the following: