Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIVYFLAG not passed to Photon Makefile in Makefile, causing trivy-adapter-photon image not to be built when TRIVYFLAG=true #21653

Open
Yuewenyuan opened this issue Feb 20, 2025 · 0 comments

Comments

@Yuewenyuan
Copy link

Expected behavior and actual behavior:

When TRIVYFLAG=true, the trivy-adapter-photon image should be compiled as part of the build process.

When setting TRIVYFLAG=true, the trivy-adapter-photon image is not being compiled. This is because the TRIVYFLAG is not being passed to the Photon Makefile during the build process. To fix this, we need to append the -e TRIVYFLAG=$(TRIVYFLAG) parameter at the end of the make build target in the main Makefile.

Steps to reproduce the problem:

  1. Set the TRIVYFLAG=true in the environment.
  2. Run the make build command.
  3. Notice that the trivy-adapter-photon image is not compiled.

Versions:
Please specify the versions of following systems.

  • harbor version: [v2.12.2]

Suggested Fix:
In the Makefile, update the build target to include the -e TRIVYFLAG=$(TRIVYFLAG) parameter, ensuring that TRIVYFLAG is passed to the Photon Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant