Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Double value parsing check #3055

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Double value parsing check #3055

wants to merge 3 commits into from

Conversation

anandwana001
Copy link
Collaborator

@auto-assign auto-assign bot requested a review from scolsen February 19, 2025 06:36
shobhitagarwal1612
shobhitagarwal1612 requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit test coverage which covers the scenario where we try to enter invalid characters in the input field?

@anandwana001
Copy link
Collaborator Author

Can we add some unit test coverage which covers the scenario where we try to enter invalid characters in the input field?

Added

shobhitagarwal1612
shobhitagarwal1612 requested changes Feb 19, 2025
View reviewed changes
app/src/test/java/com/google/android/ground/model/submission/NumberTaskDataTest.kt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the test to NumberTaskFragmentTest instead of adding tests for the data class?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fragment it only supports passing Double value, not string value

runner().inputNumber(DOUBLE_VALUE)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we customize it as needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobhitagarwal1612 shobhitagarwal1612 shobhitagarwal1612 requested changes

@scolsen scolsen Awaiting requested review from scolsen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FloatingDecimal.readJavaFormatString: NumberTaskFragment
2 participants
@anandwana001 @shobhitagarwal1612