Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide close button after data is collected #3059

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Hide close button after data is collected #3059

wants to merge 8 commits into from
+43 −70

Conversation

shobhitagarwal1612
Copy link
Member

Fixes #3050

Things done in this PR:

  1. Hide the close button when displaying the confirmation screen
  2. Handle edge case for back press on confirmation screen to directly navigate up
  3. Simplify compose UI creation of the dialog

Tested locally

@gino-m PTAL?

@shobhitagarwal1612
Simplify compose ui for confirmation dialog
0a5f92c
@shobhitagarwal1612
Hide close button after submission in DataCollectionFragment
aac696b 
* Removes the navigation icon from the toolbar after submission.
@shobhitagarwal1612
Handle back button after submission in DataCollectionFragment
bf61fb6 
*   Navigate back to the home screen after a task is submitted when the back button is pressed.
*   Extract navigation logic to a separate private method.
@shobhitagarwal1612
Move confirmation dialog logic into DataSubmissionConfirmationDialog
b496495
@shobhitagarwal1612
Remove logic for removing the compose view on close button click as t…
b04a2ab 
…he fragment itself gets dismissed
@shobhitagarwal1612
Fix import order
4a0219a
@auto-assign auto-assign bot requested a review from anandwana001 February 22, 2025 19:26
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 63.05%. Comparing base (daed8d3) to head (643929b).

Files with missing lines Patch % Lines
...datacollection/DataSubmissionConfirmationScreen.kt 52.00% 5 Missing and 7 partials ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 45.45% 2 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3059      +/-   ##
============================================
+ Coverage     62.97%   63.05%   +0.08%     
- Complexity     1302     1303       +1     
============================================
  Files           278      278              
  Lines          6781     6759      -22     
  Branches        950      948       -2     
============================================
- Hits           4270     4262       -8     
+ Misses         1890     1878      -12     
+ Partials        621      619       -2
Files with missing lines Coverage Δ
...ground/ui/datacollection/DataCollectionFragment.kt 44.44% <45.45%> (+0.44%) ⬆️
...datacollection/DataSubmissionConfirmationScreen.kt 61.11% <52.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 Awaiting requested review from anandwana001

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide close button when data is collected
1 participant
@shobhitagarwal1612