app: fix headless mode not running #2893
Conversation
dosubot
bot
added
the
size:M
|
Hello. Thanks for reporting the issue, and for the PR! The backend job is failing with a lint issue. You can run the linter locally for the backend with: I noticed this error in the App CI build jobs: |
|
I ran that command locally and it worked. What I think might be happening is that I used a more recent version of go than what you are using. The function How should we proceed? Should the go version be updated or does this CopyFS function need to be implemented other way? |
|
@DMaxter: ah ok, thanks. Yeah, I've been meaning to update Headlamp to 1.23.x so I'll do that in a separate PR. |
|
Alright. Let me know if there is something I can support with |
|
PR for new golang (still needs to be reviewed/merged) |
|
@DMaxter that golang update PR is merged now. |
| os.Exit(1) | ||
| } | ||
|
|
||
| defer os.RemoveAll(dir) |
There was a problem hiding this comment.
I don't understand this part.
Why is dir being removed when later it is being assigned to config.staticDir? (line 917)
There was a problem hiding this comment.
From the very limited knowledge I have of Go, defer seems to be an instruction to make whatever is in front to be called after the function returns.
So, what happens here is:
- Create temporary folder
- Schedule the temporary folder to be removed
- Copy the contents to it
- Serve contents of temporary folder
When the function returns, it should call this function
There was a problem hiding this comment.
According to the error on CI seems like this code never runs, so better fix it
Signed-off-by: DMaxter <[email protected]>
Signed-off-by: DMaxter <[email protected]>
Signed-off-by: DMaxter <[email protected]>
When I tried running both the version of headlamp in the Arch AUR (not official) and the AppImage in this repo I would get an error about a function not existing. This complete makes headlamp useless for my usecase in WSL2 (in one of the computers I tested).
This PR address these issues and performs the following changes:
1. Correctly uses promise when on headless mode
In https://github.com/headlamp-k8s/headlamp/blob/v0.28.1/app/electron/main.ts#L1413 , we are not awaiting the Promise returned on the previous line, so it caused the exception I first mentioned in the issue. It happened because
serverProcesswasnullwhen reaching theattachServerEventHandlersfunction. Solved by chaining athenat the end of it2. Create a temporary directory for the static assets
When using on Arch, after fixing the first exception, I got a permission denied with the AUR package. With the AppImage, it said the system was readonly. It tries to patch the baseURL in place, which is not possible for squashFS on AppImages.
The fix I provided creates a temporary folder in the system temp location, copies the assets there and uses that temporary directory as the new static assets directory, that is allowed to be written by the process
3. Add a timeout to starting the browser
I felt the need to add a timer to starting the frontend on the browser as it always opened before the backend was serving requests. This is just a simple timer before trying to open the browser with the link
Feel free to scrutinize my code as I am not a Go developer and also not very familiar with Electron
Fixes #2892