Add support for custom Maven properties in Matrix build #138
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
suggested changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks @biru-codeastromer but your misunderstood the initial request. We need to keep using buildPlugin() in the pipeline, your solution is invalid as it uses a custom pipeline which will soon diverge from the other pipelines as it stops using the library
Thanks for the insights ! Much appreciated . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jenkins-infra/pipeline-library#851
Description
This PR adds support for custom Maven properties in the Matrix build configuration for the
winprepository. The changes allow users to specify different Maven properties (e.g.,native.configuration=Releaseandnative.configuration=Debug) for parallel builds.Changes
Matrix Build Configuration:
matrixblock to define multiple axes for the build.NATIVE_CONFIGaxis with valuesReleaseandDebug.JDKaxis for JDK versions 21 and 17.Custom Maven Properties:
mavenPropsvariable to pass custom Maven properties (-Dnative.configuration=${NATIVE_CONFIG}) to themvn clean installcommand.Agent Configuration:
agentblock to dynamically select the platform (linuxorwindows) based on thePLATFORMvariable.