-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: analyze command default backend bug #966
fix: analyze command default backend bug #966
Conversation
@JuHyung-Son could you please go through this PR whenever you have some time? Thanks! |
This looks like it's just moving the functionality elsewhere? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, cli backend options are working well. and i left 2 comments
e12fea2
to
8533837
Compare
Consider the following scenario if this fix was not present:
However, using the fix I proposed, the user can also specify |
8533837
to
d378aa3
Compare
I think you hunch is right, this is a separate problem because I saw changes related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for delay, this looks good to me.
and cli works well
Now, the default value of the `backend` flag for the analyze command will be an empty string. And the `NewAnalysis` function has been modified to use the default backend set by the user if the backend flag is not provided and the `defaultprovider` is set in the config file. Otherwise, backend will be set to "openai". Fixes: k8sgpt-ai#902 Signed-off-by: VaibhavMalik4187 <[email protected]>
d378aa3
to
33ace61
Compare
No worries, I've rebased the PR to include the latest changes on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing bug.
Closes #902
📑 Description
Now, the default value of the
backend
flag for the analyze command will be an empty string. TheNewAnalysis
function has been modified to use the default backend set by the user if the backend flag is not provided and thedefaultprovider
is set in the config file. Otherwise, the backend will be set to "openai".✅ Checks