Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a get sync getItems method #112

Closed
wants to merge 3 commits into from
Closed

Adding a get sync getItems method #112

wants to merge 3 commits into from

Conversation

cunhazera
Copy link
Contributor

Fixes #109

Commentary:

  • It would be little harder to have a toSync method, because I'd need to return an instance of DeliveryClient so the items should be stored in a field, so then I could have an deliveryClient.getItems(Class.class).toSync(). If I did this, the DeliveryClient class would need a generic type at the class level, so that would break a lot of old code. Anyway, if anyone has a better idea we can talk about, to have a toSync method.

@cunhazera cunhazera mentioned this pull request Oct 5, 2020
Open
@Simply007
Copy link
Contributor

This pull request only covers only the getItems method, but there is a bunch of remaining in the delivery client (i.e. getTypes).

I would like to avoid doubling the method count in the delivery client. I would appreciate a unified approach.
It might be possible to inherit from CompletionStage and extend it with a method called toSync. This would not break any compatibility, because of inheritance and it would allow having nice and fluent syntax as described in #109 (comment).

According to the tests, I would like to not have current tests modified and just add new ones, because the functionality is also just added, not modified.

Mind the Readme - there should be the mention of the functionality too.

@Simply007 Simply007 self-requested a review October 6, 2020 07:42
Simply007
Simply007 suggested changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#112 (comment)

@Simply007
Copy link
Contributor

@cunhazera - do you have any update on this?

@Simply007
Copy link
Contributor

Hi!

This pull request has gone quiet. 👻
It’s been a while since the last update here.

If we missed anything on this issue or if you want to keep it open, feel free to do so.

Thanks for being a part of the Kentico community!

@Simply007 Simply007 closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simply007 Simply007 Simply007 requested changes

@makma makma makma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add synchronous support to the DeliveryClient
3 participants
@cunhazera @Simply007 @makma