Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: add a test to blocker list per-PR when the test is triggered manually #3740

Closed
stevekuznetsov opened this issue Jul 27, 2017 · 4 comments
Labels
area/prow Issues or PRs related to prow

Comments

@stevekuznetsov
Copy link
Contributor

It would be cool if, when a PR has a non-blocking test triggered for it manually, that either this test would automatically become part of the default trigger set and become blocking for the PR or if there were a bot command to add it to the list as well.

/area prow
/cc @Kargakis @bparees

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Jul 27, 2017
@0xmichalis
Copy link
Contributor

Seems like a munger issue. The easiest way I can think of is the SQ blocks on the context if the context exists in the PR, otherwise it is not.

/area mungegithub

@spxtr
Copy link
Contributor

spxtr commented Jul 27, 2017

@rmmh I think was interested in this.

@stevekuznetsov
Copy link
Contributor Author

Also necessary if a test gets selected by touching changed paths

@0xmichalis
Copy link
Contributor

Dupe of #1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow
Projects
None yet
Development

No branches or pull requests

4 participants