Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needs-ok-to-test is not removed on reopening of a PR #5318

Closed
0xmichalis opened this issue Nov 2, 2017 · 1 comment
Closed

needs-ok-to-test is not removed on reopening of a PR #5318

0xmichalis opened this issue Nov 2, 2017 · 1 comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.

Comments

@0xmichalis
Copy link
Contributor

openshift/origin#17148

The cherrypick robot wasn't a member of openshift at the time the PR was opened. Once it joined and the PR was reopened, tests started running but the label was not removed.

/kind bug
/area prow

cc @stevekuznetsov
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/prow Issues or PRs related to prow labels Nov 2, 2017
@stevekuznetsov stevekuznetsov mentioned this issue Nov 2, 2017
Closed
@xiangpengzhao xiangpengzhao mentioned this issue Nov 3, 2017
Merged
@xiangpengzhao
Copy link
Contributor

I send PR #5330.
Idea:

  • remove "needs-ok-to-test" label if existing when a PR is opened and found trusted
  • if a member's PR is labeled "needs-ok-to-test" accidentally (e.g., a maintainer adds it manually by mistake), just remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xmichalis @xiangpengzhao @k8s-ci-robot