Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(terminal-preview): terminal opens multiple instances on launch #18584

Open
vipexv opened this issue Feb 17, 2025 · 2 comments
Open

bug(terminal-preview): terminal opens multiple instances on launch #18584

vipexv opened this issue Feb 17, 2025 · 2 comments
Assignees
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Discussion Something that requires a team discussion before we can proceed Product-Terminal The new Windows Terminal.

Comments

@vipexv
Copy link

vipexv commented Feb 17, 2025

Windows Terminal version

1.23.10353.0

Windows build number

10.0.26100.0

Other Software

No response

Steps to reproduce

Open the Terminal.

Expected Behavior

Expected behavior is for it to only open 1 instance not multiple.

Actual Behavior

Everytime i launch the terminal, it seems to open multiple instances, and this only happens on the preview version.

Also everytime i open it through the context menu it opens 3, so 1 of them is usually in the correct path and the rest are always opened in root.

@vipexv vipexv added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 17, 2025
@FlyMandi
Copy link

I'm also on 1.23.10353.0 and have noticed this exact behaviour. This has only started happening with the most recent version and "firstWindowPreference": "defaultProfile" is set, so it's not that.

Additionally, when starting other applications, such as SKSE, two default profile and default location terminal preview windows open, when previously none did.

@carlos-zamora carlos-zamora added this to the Terminal v1.24 milestone Feb 19, 2025
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 19, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.22 Servicing Pipeline Feb 19, 2025
@carlos-zamora
Copy link
Member

carlos-zamora commented Feb 19, 2025

Thanks for filing! Looks like the persisted window layout is stored without any tabs. And even though firstWindowPreference is set to defaultProfile, we're still creating new tabs on launch!

We should take a look at how other tabbed applications handle storing state and a similar setting (open previous session).

Discussion topic: consider adding another setting to clarify if we want the last closed window to be stored

@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Discussion Something that requires a team discussion before we can proceed Product-Terminal The new Windows Terminal.
Projects
Status: To Cherry Pick
Development

No branches or pull requests

4 participants