Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell "upgrade now" hyperlink not automatically detected #18594

Open
carlos-zamora opened this issue Feb 19, 2025 · 2 comments
Open

PowerShell "upgrade now" hyperlink not automatically detected #18594

carlos-zamora opened this issue Feb 19, 2025 · 2 comments
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

Windows Terminal version

No response

Windows build number

No response

Other Software

An outdated version of PowerShell

Steps to reproduce

  1. open a powershell tab
  2. See this:
    Image

Hover over the hyperlink

Expected Behavior

The hyperlink should be detected so we can click on it to open it

Actual Behavior

It's not. The regex we use is here:

static constexpr std::array<std::wstring_view, 1> patterns{
LR"(\b(?:https?|ftp|file)://[-A-Za-z0-9+&@#/%?=~_|$!:,.;]*[A-Za-z0-9+&@#/%=~_|$])",
};

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 19, 2025
@DHowett
Copy link
Member

DHowett commented Feb 19, 2025

This works fine for me. I don't think it's a regex problem...

@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 19, 2025
@carlos-zamora carlos-zamora added this to the Backlog milestone Feb 19, 2025
@carlos-zamora
Copy link
Member Author

carlos-zamora commented Feb 19, 2025

Currently, we scan for URLs on an interval. Perhaps we should scan for URLs on hover instead.

Related: #18177 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants