Add needsUpdate to Reflector #30569
Open
Add needsUpdate to Reflector #30569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Feb 21, 2025
| @@ -21,6 +21,7 @@ class Reflector extends Mesh { | |||
| this.isReflector = true; | |||
|
|
|||
| this.type = 'Reflector'; | |||
| this.needsUpdate = false; | |||
There was a problem hiding this comment.
The problem with this new flag is that it only works in conjunction with isFacingAway. The reflector might be updated per render even if needsUpdate is set to false. This feels a bit buggy regarding how other needsUpdate flags usually work in the library.
How about renaming it to forceUpdate? The default would still be false but setting it to true forces an update no matter how the reflector is oriented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30568.
Description
Render the Reflector if needsUpdate is set to true