Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal/telemetry API public #12405

Open
jade-guiton-dd opened this issue Feb 17, 2025 · 0 comments
Open

Make internal/telemetry API public #12405

jade-guiton-dd opened this issue Feb 17, 2025 · 0 comments

Comments

@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Feb 17, 2025

Once #12217 is implemented, we now have wrappers in place to automatically add component-identifying attributes (as defined by the Pipeline Component Telemetry RFC) to log records (see #12259) and metric points / spans (see #12384).

We also have an API so components can opt out of specific attributes in case they aren't relevant to them (for example, the OTLP receiver is a singleton shared for all signals, so the signal attribute is not relevant, see code).

However, this API is currently internal while it is being worked on. We want to eventually stabilize it and make it available to components outside of core as part of the component module.

To do this:

  • The TelemetrySettings struct, which in Wrap TelemetrySettings providers to add component-identifying attributes #12384 is moved to internal/telemetry and reexported in component, should be moved back into component.
  • The API functions that take a TelemetrySettings as first argument should be turned into methods for said struct (they are currently not because that would make them publicly available through the reexport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant