Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading local images into Kind for easier development #18

Open
empovit opened this issue Aug 19, 2024 · 6 comments
Open

Allow loading local images into Kind for easier development #18

empovit opened this issue Aug 19, 2024 · 6 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@empovit
Copy link
Contributor

empovit commented Aug 19, 2024

There is a way to load local images into a Kind cluster without pushing them into a registry. This can offer a faster turnover for development, and eliminate the need in a remote registry for those who want to experiment. If we stay with Kind for development/demo, we might consider adding the local image option to the scripts.

@kannon92
Copy link
Contributor

We did this on the Kueue e2e tests if anyone is curious. I can't say I got it working with Podman instead of docker but it seems to work pretty well.

@empovit
Copy link
Contributor Author

empovit commented Aug 19, 2024

It works with Podman, needs a bit of a workaround though. See this PR.

@empovit empovit self-assigned this Aug 28, 2024
@asm582
Copy link
Contributor

asm582 commented Nov 5, 2024

@empovit do we know what is pending?

@empovit
Copy link
Contributor Author

empovit commented Nov 7, 2024

@asm582 if this has been implemented on Kind with Docker, the issue can be closed. As we discussed already, we can't use Podman because the NVIDIA container toolkit for Podman works with CDI, which isn't good for InstaSlice.

@empovit
Copy link
Contributor Author

empovit commented Nov 7, 2024

Ok, I see it implemented in emulator mode

_kind load docker-image ${IMG} --name ${KIND_NAME}
, but not in the demo https://github.com/openshift/instaslice-operator/blob/99405c97edb2362c07fe16a0bc4fbcc871258b51/deploy/setup.sh. I also think that setup.sh should move to were the rest of deployment files are.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants