Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click a left nav then hover another, first item should not stay selected #2292

Closed
jwforres opened this issue Oct 17, 2017 · 5 comments
Closed
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone

Comments

@jwforres
Copy link
Member

Click an item in the left nav that has a submenu, then hover over another item that has a submenu, you end up with something like this (clicked on Applications then hovered over Builds):

screen shot 2017-10-17 at 4 36 34 pm

@jwforres jwforres added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 17, 2017
@jeff-phillips-18
Copy link
Member

Clicking on Applications is a no-op. The display is still showing overview right?

@jwforres
Copy link
Member Author

Right, so Overview is still active, which is correct. It makes sense for Applications to be highlighted when you clicked it, but if you then hover over a different menu it felt weird to have the active one, the one you clicked, and the one you are hovering over all be in the lighter gray state.

@jeff-phillips-18
Copy link
Member

I'm not sure we want Applications to be highlighted on click since it is not active, I think that is the issue.

@spadgett
Copy link
Member

Yeah, the highlighting is a bug introduced by our workaround to make the nav keyboard accessible.

@jwforres jwforres added this to the 3.7.0 milestone Oct 23, 2017
@jwforres
Copy link
Member Author

So its specifically caused by the style in _vertical-nav.less that adds the active color when the link is focused. Clicking it gives it focus and hovering on the other ones doesn't change that.

We could trigger the style based on the is-hover class we manually add instead of using focus, but there is a delay before that class is removed which looks a little weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Development

No branches or pull requests

3 participants